mahara-contributors team mailing list archive

[Eduardo <eduardo@xxxxxxxxxxxxxxx>]

Patch works and Tested on Mahara version 1.11.0dev (2014092500). Here is
my full testing method:

1. Log in as admin
2. Go to Portfolio → Create page
3. Save
4. Click on External → Drag “Google Apps” block into the page
5. Paste link number 1
6. Save
7. Confirm Map is showing → Passed
8. Drag another “Google Apps” block into the page
9. Paste link number 2
10. Save
11. Confirm Map is showing → Passed
12. Drag another “Google Apps” block into the page
13. Paste link number 3
14. Save
15. Confirm Map is showing → Passed
16. Drag another “Google Apps” block into the page
17. Paste link number 4
18. Save
19. Confirm Maps is showing → Passed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1378645

Title:
  Google Maps "my maps" URLs breaking

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.11 series:
  Confirmed
Status in Mahara 1.8 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed

Bug description:
  The Google Apps block is broken again!

  As reported here:
  https://bugs.launchpad.net/mahara/+bug/1323495/comments/10

  It breaks for (at least) these URLs:

  https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

  https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

  https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

  https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

  I think the common thread is that these are "my maps" URLs, which have
  "/ms" in them. We have a regex for that in the code, but it expects it
  to be a maps.google.* domain name instead of www.google.*

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1378645/+subscriptions