mahara-contributors team mailing list archive

[Mahara Bot <1378645@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3801
Committed: http://gitorious.org/mahara/mahara/commit/a50ee3bd91009ee228489d4e98bc0fbb100eaeb8
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit a50ee3bd91009ee228489d4e98bc0fbb100eaeb8
Author: Son Nguyen <sonn@xxxxxxxxxxxxxxx>
Date:   Thu Oct 9 10:48:07 2014 +1300

Handle more Google Maps URLs. Bug 1378645

This patch will convert these following share links into iframe embed
code

-
https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

-
https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

-
https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

-
https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

Change-Id: If1f31357de7c0476afa8ff7ec7e464bf33830fff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1378645

Title:
  Google Maps "my maps" URLs breaking

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.11 series:
  Fix Committed
Status in Mahara 1.8 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed

Bug description:
  The Google Apps block is broken again!

  As reported here:
  https://bugs.launchpad.net/mahara/+bug/1323495/comments/10

  It breaks for (at least) these URLs:

  https://www.google.fi/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

  https://www.google.fi/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

  https://www.google.com/maps/place/90100+Oulu/@65.016667,25.466667,17z/data=!3m1!4b1!4m2!3m1!1s0x468032a8c02185c1:0x8bb02d322b12e97d

  https://www.google.com/maps/ms?msid=217233740007179193682.00045bce836893f537d23&msa=0

  I think the common thread is that these are "my maps" URLs, which have
  "/ms" in them. We have a regex for that in the code, but it expects it
  to be a maps.google.* domain name instead of www.google.*

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1378645/+subscriptions