← Back to team overview

mahara-contributors team mailing list archive

[Bug 1382159] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3823
Committed: http://gitorious.org/mahara/mahara/commit/447a16280b4a94972d1b79f4dcd1394e6b6201fd
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 447a16280b4a94972d1b79f4dcd1394e6b6201fd
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Oct 17 09:12:52 2014 +1300

Finding the dimensions of hidden textareas (Bug #1382159)

If the parents of a textarea are also hidden it returns height/width
as 0, which is no use to us. So we need to find it's height/width when
not hidden.

So added some code to:
- to clone the textarea
- make it positioned way outside the viewport
- append it to body
- find height/width
- remove the clone from body
- return the height/width

Change-Id: Ib2fa2d80b3046909ed2763545410d5d95f464b4d
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1382159

Title:
  Profile -> contact information -> address textarea not displaying
  correctly

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.11 series:
  Fix Committed

Bug description:
  For some reason, which I'm about to look into, the textarea is given a
  height of 1px and width of 0 via css - so it doesn't display
  correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1382159/+subscriptions


References