mahara-contributors team mailing list archive

[Mahara Bot <1379060@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3779
Committed: http://gitorious.org/mahara/mahara/commit/7ea93380ce279b22f2c9a7d24e1ac5e7728c9348
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 7ea93380ce279b22f2c9a7d24e1ac5e7728c9348
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 9 12:09:05 2014 +1300

Adjusting places where form error message's container appears escaped

Bug #1379060

Looks only to be a problem with $form->set_error() and block config
forms.

Change-Id: I8ac8a7c96446e1dd37a312f482f4d31ad46dae3d
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1379060

Title:
  error message shows span tag escaped

Status in Mahara ePortfolio:
  In Progress

Bug description:
  For example if I add a external feed block to a page and then add in
  gibberish for the url I get this error on save

  <span id="instconf_url_error">The feed appears to be invalid. The
  error reported was: Could not resolve host: dfd</span>

  but the problem is it's displaying the <span> as escaped html.

  This patch https://reviews.mahara.org/#/c/3731/3 deals with sorting out the basic rules from being escaped - but there are other cases where the code has specified their specific error mesaages, eg 
  $form->set_error('url', get_string('invalidfeed', 'blocktype.externalfeed',  $e->getMessage()));

  needs to have a third param false added to it and the $error message
  escaped

  $form->set_error('url', get_string('invalidfeed',
  'blocktype.externalfeed',  hsc($e->getMessage())), false);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1379060/+subscriptions