mahara-contributors team mailing list archive

[Mahara Bot <1372536@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3724
Committed: http://gitorious.org/mahara/mahara/commit/2fd431ba63698e98dc40c2b650c1d21741d3d915
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 2fd431ba63698e98dc40c2b650c1d21741d3d915
Author: Tobias Zeuch <tobias.zeuch@xxxxxxx>
Date:   Thu Sep 25 11:27:43 2014 +0200

Add separate function for right nav menu

Bug 1372536: Add a separate function to PluginArtefact, PluginInteraction and
PluginModule that lets you add menu entries especially to the right nav menu,
including top level entries.

The method right_nav in web.php still includes elements from the old menu_items
function for backwards compatibility but ignores all top level entries.

Change-Id: I91ba01f060a73575c483aa81aeb9201b11f1261f
Signed-off-by: Tobias Zeuch <tobias.zeuch@xxxxxxx>
Signed-off-by: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1372536

Title:
  PluginModule-menu items appear in two menus

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  With a module-plugin, that overwrites menu_items, the returned menu
  items appear in the main navigation and also in the top right corner.
  Both are very helpful on their own, but it should be possible to add
  an item to either of them without the other, like, have an entry only
  in the upper right corner but not in the main menu or vice versa.

  The calls are indistinguishable (as far as I see) and originate from
  web.php::main_nav, line 2683 and web.php::right_nav, line 2741

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1372536/+subscriptions