mahara-contributors team mailing list archive

[Mahara Bot <1268746@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3740
Committed: http://gitorious.org/mahara/mahara/commit/1f12435cbe86d547b54ea90a671d9b2ed62be15c
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.7_STABLE

commit 1f12435cbe86d547b54ea90a671d9b2ed62be15c
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Jul 4 12:19:04 2014 +1200

Fix E_STRICT "Only variables should be assigned by reference"

Bug 1268746

Change-Id: I438629b7bb03590b4f5875c07381f500569c80d1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1268746

Title:
  Squelch PHP 5.4+ strict standards errors

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Released
Status in Mahara 1.8 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  Mahara sets its error reporting to E_ALL (in error.php). Prior to PHP
  5.4, E_ALL, despite the name, did not include E_STRICT. Starting with
  PHP 5.4, it does include E_STRICT.

  Since Mahara has been running all this time with E_STRICT messages
  silenced, there are a lot of E_STRICT violations in the codebase, and
  on PHP 5.4+ servers, the logs are so full of them as to be useless.

  In the long term we should fix all the E_STRICT warnings, but for the
  short term we should just silence them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1268746/+subscriptions