mahara-contributors team mailing list archive

[Mahara Bot <1353153@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3575
Committed: http://gitorious.org/mahara/mahara/commit/53d733273333da13d696f2fb81b4218baca1f051
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit 53d733273333da13d696f2fb81b4218baca1f051
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 6 10:48:07 2014 +1200

Logout setting of cookie breaks upgrade from pre 1.9 to 1.9+ (Bug
#1353153)

If the user who is upgrading the site is logged into the site and is a
member of a normal (not mahara) institution it causes the upgrade to
break because the upgrade process tries to log them out and logout()
function tries to set a cookie and the cookie needs info from the
config_institution table and it doesn't exist yet.

Change-Id: Ib8bb83fc1b774cec5636af6009ebf9906349bca3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1353153

Title:
  upgrade to 1.9 error when logged in and belonging to an institution

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  If one is an institutional admin and they try to upgrade their site
  from pre 1.9 to 1.9+ they get this error

  Wed Aug 06 10:01:17.952987 2014] [:error] [pid 22070] [client
  127.0.0.1:32941] PHP Fatal error:  Uncaught exception 'SQLException'
  with message 'Failed to get a recordset: postgres7 error: [-1: ERROR:
  relation "institution_config" does not exist\nLINE 1: SELECT field,
  value FROM "institution_config" WHERE "institu...\n
  ^]

  There was a change made in 1.9 relating to language settings and one
  of the things it does is try to set a cookie relating to the
  institution language last used.

  When one upgrades it logs them out as part of the process if they are
  logged in. And it tries to set their institution set language on
  logout in 1.9 getting info from the institution_config table (which
  does not exist at this point).

  The setting of that cookie needs to be wrapped in a check to make sure
  the table exists first.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1353153/+subscriptions