← Back to team overview

mahara-contributors team mailing list archive

[Bug 1266586] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3514
Committed: http://gitorious.org/mahara/mahara/commit/d1d5149841a122bdcc158d8655c046e159551de0
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit d1d5149841a122bdcc158d8655c046e159551de0
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Jul 28 10:06:47 2014 +1200

Getting the max height from the img files correctly (Bug #1266586)

Problem existed where the cache didn't know the height of the files as
they had not been loaded before so the getting of the hightest one was
failing.

Changed it so that mahara passes in the height of the file to allow it
to fetch that instead.

Change-Id: I765ee00bd05720e8643ee97976a097d9cf394211
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1266586

Title:
  Thumbnails style image galleries display incorrect

Status in Mahara ePortfolio:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.9 series:
  In Progress

Bug description:
  How to Reproduce
  -------------------------------
  1. add a gallery to a profile page
  2. select the the thumbnails style option 
  3. select the show descriptions check box 
  4. save the gallery 

  Result 
  --------------------
  The gallery appears to be correct until a refresh of the page is done.  The gallery will then overlap the images and descriptions and display a scroll bar to the right of the gallery.  

  Expected Result - would be for the gallery images & descriptions to be
  displayed without being overlapped

  see attached screen shot for more details

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1266586/+subscriptions


References