← Back to team overview

mahara-contributors team mailing list archive

[Bug 1388665] Re: Use the favicon identification code for social media profiles

 

Hi Kristina,

The social media profile already gets the favicon for the sites, using
exactly the same code as the iframe admin page. For instance if I enter
https://github.com/agwells as a social media account for myself, I see
the github.com favicon.

On the backend, they both call the function favicon_display_url($host)
in lib/web.php. This function, in turn, uses a config variable
$cfg->favicondisplay, which is set to
"http://www.google.com/s2/favicons?domain=%s"; by default.

Cheers,
Aaron

** Changed in: mahara
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1388665

Title:
  Use the favicon identification code for social media profiles

Status in Mahara ePortfolio:
  Invalid

Bug description:
  When you create a new social media profile, the identifying icon is
  the default globe. This is not great when you want to add a lot of
  social media profiles that Mahara doesn't know about.

  What about repurposing the code we use for identifying a site and
  displaying its favicon as we do in the iframe sources? Richard wrote
  some nifty code to fetch the favicon from any site. If it can't be
  found, the default icon is displayed. If we wanted to get very fancy,
  we could also add the option to specify a favicon (like we can for the
  iframe sources).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1388665/+subscriptions


References