mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Having taken a look at this the get_comments function contains the
comment count in it as well and the comment count here does take into
account whether a user can see / not see the private comments.

So I've altered the places in artefact/blog/lib.php and
artefact/internal/blocktype/textbox/lib.php to use the get_comments()
rather than count_comments().

The count comments look to be better suited to the getting of stats in
the lib/registration.php file where it doesn't matter if the comment is
private or not.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1393223

Title:
  comment count is wrong when private comments are in play

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The comment count displayed on a blog block is not correct if there
  are private comments and the viewer of the page can not see the
  private comments.

  Scenario: A user leaves three comments on a journal entry - 2 public
  and 1 private

  The user should see the comment count as 3 as they can see all the
  comments.

  The journal/page owner should also see the comment count as 3 as they
  can see all the comments as well.

  Another user that can see the page should only see the comment count
  as 2 - because they cannot see the private comment.

  Currently the count_comments() function doesn't take into account the
  difference between public and private comments and who can/cannot see
  them.

  Will mark this bug as high as it is needed to be fixed for Bug
  #1037531

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1393223/+subscriptions