mahara-contributors team mailing list archive

[Mahara Bot <1393223@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3978
Committed: http://gitorious.org/mahara/mahara/commit/5e066eca5a842c8d5f4ea0fb8e14e7d01df9d788
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 5e066eca5a842c8d5f4ea0fb8e14e7d01df9d788
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Nov 17 08:38:53 2014 +1300

Getting correct comment count for blocks (Bug #1393223)

The blog and textbox (notes) blocks return incorrect comment count if
there are private comments and the user is not allowed to see the
private comment.

Change-Id: I20f7f51ec2e948d37a09c5447340aab3bef31a13
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1393223

Title:
  comment count is wrong when private comments are in play

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  The comment count displayed on a blog block is not correct if there
  are private comments and the viewer of the page can not see the
  private comments.

  Scenario: A user leaves three comments on a journal entry - 2 public
  and 1 private

  The user should see the comment count as 3 as they can see all the
  comments.

  The journal/page owner should also see the comment count as 3 as they
  can see all the comments as well.

  Another user that can see the page should only see the comment count
  as 2 - because they cannot see the private comment.

  Currently the count_comments() function doesn't take into account the
  difference between public and private comments and who can/cannot see
  them.

  Will mark this bug as high as it is needed to be fixed for Bug
  #1037531

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1393223/+subscriptions