← Back to team overview

mahara-contributors team mailing list archive

[Bug 1394330] A patch has been submitted for review

 

Patch for "master" branch: https://reviews.mahara.org/3994

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1394330

Title:
  Improper use of the parseInt javascript function

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The parseInt() function needs to specify that it is using radix 10

  Older browsers use the octal radix (8) as default so parseInt('010')
  will return '8' rather than '10' that we might expect.

  In many places the function is used correctly, eg: parseInt(match[1],
  10);

  But not all places are indicating to use a base 10 radix.

  So I'll clean up the places it is not used so that we know to return a
  base 10 number.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1394330/+subscriptions


References