← Back to team overview

mahara-contributors team mailing list archive

[Bug 1394754] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4013
Committed: http://gitorious.org/mahara/mahara/commit/0a547afc60d4a88d5b91ad8b61d1d66f9661e56c
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 0a547afc60d4a88d5b91ad8b61d1d66f9661e56c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 21 10:20:28 2014 +1300

Making sure options exist for _get_cli_params() (Bug 1394754)

Change-Id: I4f75dfc9f34c3f9e3f01d8d459b6ec7a43f13689
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1394754

Title:
  calling _get_cli_params() when no params present needs fixing

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Noticed this when testing something else

  The _get_cli_params() function doesn't check if there are argv options
  before trying to array_search/array_slice/foreach them

  need to wrap it in a if (!empty($options)) {  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1394754/+subscriptions


References