mahara-contributors team mailing list archive

[Mahara Bot <1400514@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4066
Committed: http://gitorious.org/mahara/mahara/commit/ee4a55fd5099dcbf269d5d263353f53b39216053
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit ee4a55fd5099dcbf269d5d263353f53b39216053
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Dec 9 11:16:58 2014 +1300

Making sure empty $values parameter is sent as array() (Bug #1400514)

To test: checkout master - try and add a comment to a page on page
reload you should get an error

With patch - adding/viewing comments should work again

Change-Id: Ic32a5f7daf273385b745c57622abac369e388197
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1400514

Title:
  Unable to load page after submitting a comment on a view

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Affects - latest master - due to adodb upgrade

  Get error:

  [WAR] 72 (lib/errors.php:745) Invalid values parameter sent to get_recordset_sql.
  Call stack (most recent first):

      log_message("Invalid values parameter sent to get_recordset_sql...", 8, true, true) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:95
      log_warn("Invalid values parameter sent to get_recordset_sql...") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:745
      SQLException->__construct("Invalid values parameter sent to get_recordset_sql...") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:457
      get_recordset_sql(" SELECT aa.artefact, a...", "", "", "") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:660
      get_records_sql_array(" SELECT aa.artefact, a...", "") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/artefact/lib.php:1120

  
  The problem is now that adodb is upgraded it is more strict on what it accepts as $values

  Needs to be empty array() and not empty string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1400514/+subscriptions