← Back to team overview

mahara-contributors team mailing list archive

[Bug 1400975] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4073
Committed: http://gitorious.org/mahara/mahara/commit/0a802bbe4bdc3cbe9f9bfcbbcf9dd2434b220c27
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 0a802bbe4bdc3cbe9f9bfcbbcf9dd2434b220c27
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Dec 10 16:27:30 2014 +1300

Add type hints to dml.php methods

Bug 1400975

Change-Id: I0b7145a6febdb9a5e7c32da9e5ae6cc138840f9b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1400975

Title:
  Add type hints to dml.php methods

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Following up on patch https://reviews.mahara.org/#/c/3985/ , I think
  it'd be a good idea to add PHP type hints to all the applicable method
  params in dml.php, so that people get warning messages if they're
  passing in the wrong types of params. That should make it easier to
  troubleshoot problem code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1400975/+subscriptions


References