← Back to team overview

mahara-contributors team mailing list archive

[Bug 1399446] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4082
Committed: http://gitorious.org/mahara/mahara/commit/71556b3a3dfc969e6bcb98b46ce70b24e1087318
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 71556b3a3dfc969e6bcb98b46ce70b24e1087318
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Dec 12 07:56:04 2014 +1300

Properly concat lang strings in webservices (Bug #1399446)

Change-Id: Ib728376b9262bc0bcd45c3f72abba4903dede902
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1399446

Title:
  Need to properly concat lang strings for webservices

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Currently there are places where the text displayed to screen is in
  the format of:

  $html = get_string('stringidentifier') . $variable;

  and

  $string['stringidentifier'] = 'Example: ';

  But that can lead to problems with translations so they need to be:

  $html = get_string('stringidentifier', 'section', $variable);

  and

  $string['stringidentifier'] = 'Example: %s';

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1399446/+subscriptions


References