← Back to team overview

mahara-contributors team mailing list archive

[Bug 1393621] Re: split the webservices/functions.php into user / group / institution functions for better code separation

 

Ok, have gone almost with what I mentioned in original report except
that the name of the file in  the functions directory is based on the
classname field in the external_functions table and therefore the class
the file holds.

So we have:
webservices/functions/mahara_user_external.php - for user functions
webservices/functions/mahara_group_external.php - for group functions
webservices/functions/mahara_institution_exteranl.php - for institution functions


** Changed in: mahara
       Status: Confirmed => In Progress

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1393621

Title:
  split the webservices/functions.php into user / group / institution
  functions for better code separation

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Currently the classes mahara_user_external, mahara_group_external, and
  mahara_institution_external are all within the
  webservices/functions.php file.

  I think as we add more functions to that file it will get quite large.
  So for easier editing will be worth breaking that up into a structure
  like:

  webservices/functions/user.php - for user functions
  webservices/functions/group.php - for group functions
  webservices/functions/institution.php - for institution functions

  this way if we want to add another set of functions say 'collection' it would be a matter of adding in
  webservices/functions/collection.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1393621/+subscriptions


References