mahara-contributors team mailing list archive

[Mahara Bot <1399246@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4131
Committed: http://gitorious.org/mahara/mahara/commit/f215dbcae4024079f4e7a31967cb0b76633b48e9
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit f215dbcae4024079f4e7a31967cb0b76633b48e9
Author: Mike Kelly <m.f.kelly@xxxxxxxxxx>
Date:   Thu Dec 4 15:24:48 2014 +0000

Fix PDFs SAMEORIGIN error when using subdomains (Bug #1399246)

X-Frame SAMEORIGIN error is thrown when viewing an embedded PDF on a
user's View, if Mahara is set up to use subdomains.

This is because the current page url has the subdomain part, but the PDF
iframe does not. Group views and page editing interface are not
affected.
This patch adds the subdomain part to the iframe url, and the PDF url,
as required.

Change-Id: I7e5856d8cfcd6ac7e2df71859c1b18d3f561bfd1
Signed-off-by: Mike Kelly <m.f.kelly@xxxxxxxxxx>
Signed-off-by: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1399246

Title:
  PDF embeds fail in sites with subdomains for user pages

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix

Bug description:
  The PDF content block fails to render the PDF iframe in a user's View
  if Mahara is set up to have subdomain urls for users, e.g.
  http://mikekelly.mymahara.org/mikes-page

  This is due to the X-Frame SAMEORIGIN rule enforced for Mahara pages.
  The PDF is served from the main domain, while the View page is served
  from the subdomain.

  This does not affect group Views, or the editing interface for Views,
  where the user identifier subdomain part is not used in the url.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1399246/+subscriptions