← Back to team overview

mahara-contributors team mailing list archive

[Bug 1416935] Re: Incorrect debug message

 

Thanks for the bug report! You're right, the function names in that
warning message are incorrect. It appears I just wrote them wrong when
writing patch https://reviews.mahara.org/#/c/3453/1 and nobody noticed.

I'll submit a patch to correct this.

Cheers,
Aaron

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/15.04
   Importance: Undecided
       Status: New

** Changed in: mahara/1.10
       Status: New => In Progress

** Changed in: mahara/15.04
       Status: New => In Progress

** Changed in: mahara/1.10
   Importance: Undecided => Low

** Changed in: mahara/15.04
   Importance: Undecided => Low

** Changed in: mahara/1.10
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.04
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/1.10
    Milestone: None => 1.10.3

** Changed in: mahara/15.04
    Milestone: None => 15.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416935

Title:
  Incorrect debug message

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 15.04 series:
  In Progress

Bug description:
  The debug info in the following section appears to be incorrect

  /mahara/auth/lib.php:
   2604      public static function save_instance_config_options($values, Pieform $form) {
   2605          throw new SystemException('This plugin claims to have instance config but does not define a '
   2606:            . 'submit_instance_config_options() method. Most likely it is still using the get_config_options() '
   2607             . 'method for this purpose. Please ask the developer to upgrade the plugin.');
   2608      }

  I believe that
  submit_instance_config_options()
  should be changed to
  save_instance_config_options()

  and
  get_config_options()
  should be changed to
  save_config_options()

  This was encountered when attempting to install the (oldish)
  Shibboleth plugin on Mahara 1.10.

  Please ask if you require more information.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416935/+subscriptions


References