mahara-contributors team mailing list archive

[Mahara Bot <1416935@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4249
Committed: http://gitorious.org/mahara/mahara/commit/3e0d955f79b850178a5584ab21f1d80ad3a79271
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 3e0d955f79b850178a5584ab21f1d80ad3a79271
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Feb 3 18:02:02 2015 +1300

Incorrect function names in auth plugin debugging message

Bug 1416935

Change-Id: I7f42d4907b523dbb74c8f896f1ca3b01449a0e1a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416935

Title:
  Incorrect debug message

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  The debug info in the following section appears to be incorrect

  /mahara/auth/lib.php:
   2604      public static function save_instance_config_options($values, Pieform $form) {
   2605          throw new SystemException('This plugin claims to have instance config but does not define a '
   2606:            . 'submit_instance_config_options() method. Most likely it is still using the get_config_options() '
   2607             . 'method for this purpose. Please ask the developer to upgrade the plugin.');
   2608      }

  I believe that
  submit_instance_config_options()
  should be changed to
  save_instance_config_options()

  and
  get_config_options()
  should be changed to
  save_config_options()

  This was encountered when attempting to install the (oldish)
  Shibboleth plugin on Mahara 1.10.

  Please ask if you require more information.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416935/+subscriptions