mahara-contributors team mailing list archive

[Mahara Bot <1364229@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3611
Committed: http://gitorious.org/mahara/mahara/commit/e5a0f676901c36d489d8b7d8fde9f3c972ce1e48
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit e5a0f676901c36d489d8b7d8fde9f3c972ce1e48
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Mon Jul 28 12:03:08 2014 +1000

(Bug1364229) Upload CSV email addr and username cache optimisation.

This patch optimises the validation function by getting a list
of known email addresses and usernames prior to entering the
validation loop.

Test runs with 2000 preexisting users using XHProf showed a
reduction in execution time from 6.5 seconds to 3.8 seconds,
with an increase in memory use of approximately 1.3MB.

Change-Id: I099f1e3b7d459538b79b78afce271f582ec4a24c
Signed-off-by: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1364229

Title:
  Uploadcsv email addr and username cache

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  We can speed the validation of email addresses and usernames by doing
  a single query for each of usernames, email addresses and internal
  email addresses prior to entering the validation loop.

  Test runs with 2000 preexisting users using XHProf showed a reduction
  in execution time from 6.5 seconds to 3.8 seconds, with an increase in
  memory use of approximately 1.3MB.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1364229/+subscriptions