mahara-contributors team mailing list archive

[Mahara Bot <1373226@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3719
Committed: http://gitorious.org/mahara/mahara/commit/14439aca7bd8728bfcf59a94e50505e4956b0ed5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 14439aca7bd8728bfcf59a94e50505e4956b0ed5
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Wed Sep 24 14:54:12 2014 +1000

Bug1373226 Fix handling of missing plugin.

Fix the handling of disabling a plugin when we find that the files
for a module are missing.

Change-Id: I706a9c4fd3c86fb1a0e330bb77c40d5e6d888a52
Signed-off-by: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1373226

Title:
  Missing plugins not disabled cleanly.

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  While working on bug505732, I've found that having data but not files
  for a plugin results in the same errors described in bug629209
  (Mahara: Site unavailable. A nonrecoverable error occured. This
  probably means you have encountered a bug in the system).

  This is because the plugin isnot marked inactive when the safe_require
  fails, and later code doesn't check whether a plugin is active before
  attempting to again require and use the plugin.

  With the patch that I intend to  submit to Gerrit, the page is loaded
  as normal, with the missingplugindisabled message included.

  (Currently tested with the extensions page; I've seen that I need to
  make further changes to cover other cases where the plugin is also
  used without the active flag being checked).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1373226/+subscriptions