← Back to team overview

mahara-contributors team mailing list archive

[Bug 1399246] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4266
Committed: http://gitorious.org/mahara/mahara/commit/586f6918a6659b1b4b5456427947bcd205d7742f
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 586f6918a6659b1b4b5456427947bcd205d7742f
Author: Mike Kelly <m.f.kelly@xxxxxxxxxx>
Date:   Thu Jan 22 10:46:44 2015 +0000

Fix PDFs SAMEORIGIN error when using subdomains (Bug #1399246)

Previous fix didn't work when page was viewed by third parties.
The subdomain address for the iframe needs to be derived from the page
author, not the current user.

Change-Id: Ic3669dd01fbe600ed2e9cf74b939ef96a84addca
Signed-off-by: Mike Kelly <m.f.kelly@xxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1399246

Title:
  PDF embeds fail in sites with subdomains for user pages

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix

Bug description:
  The PDF content block fails to render the PDF iframe in a user's View
  if Mahara is set up to have subdomain urls for users, e.g.
  http://mikekelly.mymahara.org/mikes-page

  This is due to the X-Frame SAMEORIGIN rule enforced for Mahara pages.
  The PDF is served from the main domain, while the View page is served
  from the subdomain.

  This does not affect group Views, or the editing interface for Views,
  where the user identifier subdomain part is not used in the url.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1399246/+subscriptions


References