← Back to team overview

mahara-contributors team mailing list archive

[Bug 1051844] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3728
Committed: http://gitorious.org/mahara/mahara/commit/141ee71b4a56c14023a7b3f2b7932934895bce0c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 141ee71b4a56c14023a7b3f2b7932934895bce0c
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Mon Dec 29 09:30:10 2014 +1100

Bug1051844: Fix block configure dialog width.

The configure dialog for blocks is currently set to a fixed width via
Javascript, but there is no handler for browser resizing and it results in the
dialogue being very wide for the sake of just one line when a license agreement
is enabled.

Fix this issue by making all dimensions percentages, and using a combination of
max-width: 90% and width: max-content. In addition, make the dialog fixed
position with its own scrollbars as needed (the body's scrollbar is disabled
when the dialog is shown).

Contextual help's width code and CSS is also adjusted so that it wraps within
dialog boxes rather than pushing the width out.

Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1051844

Title:
  when editing a file download artefact and the licence acceptance is
  on, the entire screen is used

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  using chrome  21.0.1180.89 Debian wheezy/sid (154005)

  It uses the entire screen, whereas I would think it should use a text
  wrap and use the normal size (without the agreement).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1051844/+subscriptions


References