mahara-contributors team mailing list archive

[Mahara Bot <1421444@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4273
Committed: http://gitorious.org/mahara/mahara/commit/f6cafa680f85e0bdf7f6d66e5c928385b7e56419
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f6cafa680f85e0bdf7f6d66e5c928385b7e56419
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Feb 13 12:25:07 2015 +1300

Make the embed code regex accept newlines

Bug 1421444

Change-Id: I9bfc571d55a2916f89bdef980b5db316715530e1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1421444

Title:
  Error trying to use an embed code with line breaks

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  I noticed this while testing out a Kaltura embed code that was
  mentioned on the mahara.org forums:
  https://mahara.org/interaction/forum/topic.php?id=6693&offset=0&limit=10#post28253

  I noticed that the embed code provided by the user worked in Mahara
  1.9 & 1.10, but not in 15.04dev. When I tried to enter this embed code
  in 15.04dev, I received a form validation error: "Invalid URL or embed
  code".

  After running git bisect, I discovered that it was a problem in the
  validation regex we added for Bug 1381807. Specifically, the regex
  errors out when trying to validate an embed code that contains line
  breaks. If I delete the line breaks and make the embed code all one
  line, it works.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1421444/+subscriptions