← Back to team overview

mahara-contributors team mailing list archive

[Bug 1388678] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4294
Committed: http://gitorious.org/mahara/mahara/commit/e9eb75b5c0bf98826bdd34e703512b1f56d88134
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit e9eb75b5c0bf98826bdd34e703512b1f56d88134
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Feb 19 11:19:25 2015 +1300

Remove superfluous folder in archived submissions (Bug #1388678)

As we add the date/time of the archive to the file name there is no
need to put it in a subdir named by date/time.

Change-Id: I8446c5f410e8502e4ab97802da0438ff428e0c32
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1388678

Title:
  Remove superfluous folder in archived submissions

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Mahara 1.10+

  When you archive submissions, the path to the actual file is like
  /var/lib/maharadata/110stable/submission/6/1414376651/ with
  "submission" being the folder for all submissions, "6" being the
  folder for the user and then the next subfolder being a timestamp for
  when the archive was created. Only then do you get to the actual file.

  I think we can safely remove the timestamp folder as each submission
  has a serialized number at the end. Disadvantages of the timestamp
  folder:

  1. It is not clear unless you are a dev that the number is a timestamp.
  2. Even if you know it's a timestamp, you'd need to calculate first if it's the one file in that folder that you need or not.
  3. It doesn't add value because the file names are unique.

  Advantages of removing the folder:

  1. You can see all archived files from one user in one folder in chronological order. That makes it easier to review the files quickly and find the ones you are looking for.
  2. One level less of hierarchy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1388678/+subscriptions


References