← Back to team overview

mahara-contributors team mailing list archive

[Bug 1397005] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4047
Committed: http://gitorious.org/mahara/mahara/commit/a3f12ab1616931144818bff2bd96816110a56cef
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a3f12ab1616931144818bff2bd96816110a56cef
Author: aceMa <h.manthey@xxxxxxxxx>
Date:   Mon Dec 1 09:36:29 2014 +1300

Do square thumb images while preserving ratio (Bug #1397005)

I've taken what aceMa provided in bug report and made it a replacement
for the square thumbs option rather than a new option as we don't need
two square thumb options.

I've tweaked it a bit more and hopefully have got the padding/ratio
stuff more consistent and not using hardcoded numbers so much

And getting it to show descriptions/captions below frame

Change-Id: Iafc0ec8a8132d1bef5401b3ebd49e3df013fddc3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1397005

Title:
  Image Gallery option "square thumbnails" distorts displayed images
  when their width and height are not equal.

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  When defining an image gallery a user can choose the option "square thumbnails". This results in a Layout that shows the images distorted when their width and height are not equal. In most cases this is not the best result. 
  Version: 1.10.0, 1.9.3 (approved) and others
  I made a quick fix for that by adding a new option that renders the images to fit in the defined square.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1397005/+subscriptions


References