mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

In fact checking if device is mobile only every needs to be done one per
session and not once per page load - as the device is not likely to
change mid stream (unless dev testing) so we don't want prod sites
testing for it on every page/block/artefact load.

** Summary changed:

- Mobile detect is checking for UA string twice
+ Mobile detect is being called too many times

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
    Milestone: None => 15.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1427031

Title:
  Mobile detect is being called too many times

Status in Mahara ePortfolio:
  In Progress

Bug description:
  In init we call isMobile() twice and that can be expensive. For me it
  meant calling Mobile_Detect::match        524 times rather than 262
  times when we call it once and remember it's answer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1427031/+subscriptions