mahara-contributors team mailing list archive

[Mahara Bot <1427031@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4336
Committed: http://gitorious.org/mahara/mahara/commit/9813cbb92d6b35ecf80f8b145a36a3e4b58a1fd1
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 9813cbb92d6b35ecf80f8b145a36a3e4b58a1fd1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Mar 2 15:34:08 2015 +1300

Reducing the number of calls to Mobile_Detect->isMobile() (Bug #1427031)

We seem to be calling it on every page load - so for a page with lots
of blocks it means a lot of calls.

When really we should call it once when a user first arrives as they
won't be switching devices during their session.

Change-Id: Id939ad83c5acfdbcdd358691def25bd2e5f5a592
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1427031

Title:
  Mobile detect is being called too many times

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  In init we call isMobile() twice and that can be expensive. For me it
  meant calling Mobile_Detect::match        524 times rather than 262
  times when we call it once and remember it's answer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1427031/+subscriptions