mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Hi Jawyei,

Thank you for you bug report and fix. You are correct in that the pages
shouldn't be listed there if they are outside the access time.

I've added your fix to the review tracker:
https://reviews.mahara.org/#/c/4522/

Cheers

Robert

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
    Milestone: None => 15.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1437929

Title:
  expired shared pages still display in groups

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When a page is shared with a group it appears in Group Pages->Pages
  shared with this group. If the page has a time restriction, it will
  still show in Pages shared with this group even if the end date has
  expired or if the start date is has not begun. The permission are
  correct in that if a user who does not have permission to view the
  page outside of the time restriction tries to access it, they cannot
  access the page.

  It would be better if Pages shared with this group only lists pages
  that is accessible to group. This can be done by altering line 3997 in
  ./lib/view.php in function  get_sharedviews_data($limit=10, $offset=0,
  $groupid)  from

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?);

  to

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?) AND (a.startdate <= current_timestamp OR a.startdate IS NULL) AND
  (a.stopdate > current_timestamp OR a.stopdate IS NULL)';

  Checked on version 1.8 and 1.10.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1437929/+subscriptions