mahara-contributors team mailing list archive

[Mahara Bot <1437929@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4522
Committed: http://gitorious.org/mahara/mahara/commit/94e25ce5edf709c0785be6268d7ed86a6cee327d
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 94e25ce5edf709c0785be6268d7ed86a6cee327d
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Mar 30 12:53:40 2015 +1300

Stopping display of pages in shared to group if outside access time

Bug 1437929

If a page that is shared to a group has their stop date before current
time or start date in the future don't display them on group homepage
in the "Pages shared with this group" section.

Change-Id: Idc605047184e2b8e04ef2b6c17e53f469ac8cd2f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1437929

Title:
  expired shared pages still display in groups

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When a page is shared with a group it appears in Group Pages->Pages
  shared with this group. If the page has a time restriction, it will
  still show in Pages shared with this group even if the end date has
  expired or if the start date is has not begun. The permission are
  correct in that if a user who does not have permission to view the
  page outside of the time restriction tries to access it, they cannot
  access the page.

  It would be better if Pages shared with this group only lists pages
  that is accessible to group. This can be done by altering line 3997 in
  ./lib/view.php in function  get_sharedviews_data($limit=10, $offset=0,
  $groupid)  from

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?);

  to

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?) AND (a.startdate <= current_timestamp OR a.startdate IS NULL) AND
  (a.stopdate > current_timestamp OR a.stopdate IS NULL)';

  Checked on version 1.8 and 1.10.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1437929/+subscriptions