mahara-contributors team mailing list archive

[Mahara Bot <1443282@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4596
Committed: http://gitorious.org/mahara/mahara/commit/5de39ecf0e70a7ff12e0d1a7d7498b6ae9c8937c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 5de39ecf0e70a7ff12e0d1a7d7498b6ae9c8937c
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Apr 13 19:10:41 2015 +1200

Bug 1443282: Show the proper author in feedback notifications

Unfortunately this doesn't work for anonymous feedback, because
the notification_internal_activity table only has an integer
column for the userid in the "from" column. To handle anonymous
feedback we would need a string for the "from" column.

Change-Id: Ia429a548b371d30166775e51f95cd5998062445f

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443282

Title:
  Feedback notifications list "System" for the "From" field

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  To replicate:

  1. Log in as user A and create a page.
  2. Allow feedback on the page. Make the page public.
  3. Log in as user B and put the page on your watchlist.
  4. Log in as user A and place feedback on the page.

  Expected result: User B should receive a notification in their inbox about the comment, showing user A as the author.
  Actual result: User B receives a notification in their inbox, but the author is "System".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443282/+subscriptions