mahara-contributors team mailing list archive

[Mahara Bot <1442150@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4619
Committed: http://gitorious.org/mahara/mahara/commit/eed165733beebd8347f6dc388d25aacb4ab8fd4c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit eed165733beebd8347f6dc388d25aacb4ab8fd4c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Apr 10 09:33:05 2015 +1200

Changing the switch's text to yes/no for delete logo (Bug #1442150)

To make the switch button's function more logical.

Change-Id: Ia7714a50c91d7cbf0d9c9c64745b52be62838340
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1442150

Title:
  Replace "delete logo" switch with a checkbox

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  I noticed another switchbox that would make more sense as an old-
  fashioned checkbox. When you upload an institution logo, there's a
  checkbox to delete the logo the next time you save the institution.

  This makes more sense as a checkbox than as a switchbox. The switchbox
  implies a persistent change in a setting. Like a light switch, it will
  remain in position until you flick it off. But this particular setting
  is no persistent. It's just indicating that you want to do an action
  this one time.

  So we should change it back to a checkbox. Or maybe change its text to
  say "Yes" and "No" rather than "On" and "Off".

  To replicate:

  1. Edit "No institution"
  2. Upload a logo file
  3. Save
  4. Edit "No institution" again
  5. Below the uploaded logo, you'll see a setting to allow you to delete the uploaded logo

  Expected result: This should be a checkbox, because it's a one-time
  action that will be triggered when you hit save

  Actual result: It's a switchbox

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1442150/+subscriptions