mahara-contributors team mailing list archive

[Mahara Bot <1444229@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4621
Committed: http://gitorious.org/mahara/mahara/commit/29053d1b096b03bf0adfc0820a2150461312f168
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 29053d1b096b03bf0adfc0820a2150461312f168
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Apr 15 14:38:22 2015 +1200

Explicitly tell the template to use the AJAX block loader

Bug 1444229: It was hacky to rely on the block content being empty
to signal the AJAX block loader. We should tell it to do so explicitly.

Change-Id: I9816c43c96ffed85282ac0d874fa5bfe1ca62e00

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1444229

Title:
  Signal the AJAX block loader with a flag instead of empty block
  content

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  When I implemented the AJAX block loader, I wrote it so that the AJAX
  block loader is used, if a block's content is empty. This is a rather
  hacky way to do it, though, because sometimes a block just has empty
  content. (See Bug 1443832)

  We should instead have a specific way for the block to communicate to
  the template "Use the AJAX block loader". This can probably be a flag
  of some sort on the block object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1444229/+subscriptions