mahara-contributors team mailing list archive

[Mahara Bot <1364170@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4262
Committed: http://gitorious.org/mahara/mahara/commit/5bd89c64ff1e30e6c1e9196246d81add53dfe826
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 5bd89c64ff1e30e6c1e9196246d81add53dfe826
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Sep 2 11:29:57 2014 +1200

Checking the remoteusername for parent auth better (Bug #1364170)

Currently it checks lowercase username against the same username

But we need to compare apples wuith apples so the subquery also needs
to return lowercase username.

Change-Id: Icbe65e12d415be6f943399185c828166ed8a98d4
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1364170

Title:
  Parent auth fails due to mixed case checking

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  Currently in the auth/user.php [around line 187] there is  a query
  that is matching lower(username) against username

  At the very least it should be lower(u.username) against us.username

  however the whole sql query could be tidied up to function better.

  Normally, usernames are email addresses and are stored as lowecase
  strings - but sometimes you need a username that is not lowercase and
  so this check fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1364170/+subscriptions