mahara-contributors team mailing list archive

[Aaron Wells <1229660@xxxxxxxxxxxxxxxxxx>]

To expand on this some more, the "lastinstitution:" is an example of the
obscure feature of "user tags". These were added in Mahara 1.5 (See Bug
800926), but we never wrote any code that uses them except for the
"members who have left an institution" feature.

You can manually set and view user tags via the account settings page.
Just log in as an admin, go to a user's account settings, and you'll
have a tag selector!

So the specific problem here is that a user shouldn't be able to add the
"lastinstitution:" tag manually like that. It's supposed to be hidden.

There are two ways we could fix this.

1. The hacky way: Edit the SQL in taglist.php (which is the JSON script
that generates the list of tags for the tag selector pieform element) so
that it is hardcoded to ignore tags that start with "lastinstitution:"

2. The more robust way: Add a "hidden" flag column to the usr_tag table.
Then alter taglist.php (and all the other places that access usr_tag) so
that they don't display tags marked as "hidden". This will replace the
existing code that has "lastinstitution:" hardcoded in.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1229660

Title:
  tag "lastinstitution:..." shows up for admin under "my tags"

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When you are an admin on a multitenannted Mahara site, you see tags of
  "lastinstitution:..." in your list of tags when users have left an
  institution.

  These are for the functionality of allowing the admin to see "People
  who have left a given institution" on the "Administration ->
  Institutions -> Members" screen.

  This tag should not show up in an admin's list of tags though as they
  are not that admin's tags and he shouldn't really hand those tags out.

  To replicate:

  1. Clean Mahara install. Log in as admin.
  2. Create Institution A
  3. Create User 1
  4. Go to User 1's account settings page, go down to the "Institution Settings" section at the bottom, and add them to Institution A.
  5. Return to User 1's account settings page, and remove them from Institution A.
  6. Go to admin's Portfolio section and create a page.
  7. On the "Edit title and description" screen, at the "Tags" field, click the "Show my tags" link.

  Result: "lastinstitution:institutiona" shows up as one of the tags.
  Expected result: "lastinstitution:institutiona" should not be listed as one of the tags.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1229660/+subscriptions