mahara-contributors team mailing list archive

[Aaron Wells <1455265@xxxxxxxxxxxxxxxxxx>]

This problem is only present in Mahara 15.04 & 15.10dev, and it's only
on block configs, not TinyMCE's in other situations (like a page
description).

Using git bisect I've traced it to this commit:

commit 141ee71b4a56c14023a7b3f2b7932934895bce0c
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Mon Dec 29 09:30:10 2014 +1100

    Bug1051844: Fix block configure dialog width.
    
    The configure dialog for blocks is currently set to a fixed width via
    Javascript, but there is no handler for browser resizing and it results in the
    dialogue being very wide for the sake of just one line when a license agreement
    is enabled.
    
    Fix this issue by making all dimensions percentages, and using a combination of
    max-width: 90% and width: max-content. In addition, make the dialog fixed
    position with its own scrollbars as needed (the body's scrollbar is disabled
    when the dialog is shown).
    
    Contextual help's width code and CSS is also adjusted so that it wraps within
    dialog boxes rather than pushing the width out.
    
    Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356

So it appears that it's a side effect of the code that we added to keep
the block config from getting too wide when there was a wide piece of
text in it. Perhaps what we need to do is hook into the TinyMCE
fullscreen button and make it toggle the max-width and max-content on
the dialog?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  TinyMCE "full screen" button doesn't work in block config

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

  To replicate:

  1. Create a page
  2. Go to the "Edit Content" tab
  3. Put a text block onto the page
  4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen button (it's on the right end of the second row of buttons)
  5. Click the "Fullscreen" button

  Expected result:
  TinyMCE goes to full screen (fills the whole browser window)

  Actual result:
  TinyMCE only fills the block config iframe. This actually makes it *smaller* than before.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions