mahara-contributors team mailing list archive

[Mahara Bot <1450705@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4785
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/267f6bc2b7e61f0a9cb6c0598a884af714460495
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 267f6bc2b7e61f0a9cb6c0598a884af714460495
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Fri May 22 13:33:18 2015 +1200

Make sure TinyMCE shows up on Feedback forms after failure to submit

Bug 1450705: The normal Wysiwyg Pieform element's "onload()" can't
handle the TinyMCE in the feedback area, because of the additional
Feedback logic for hiding & showing the Feedback form.

Change-Id: Ic2c7ad8c2ce8720ba1fcaf19c3ec71b6529b4ff0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1450705

Title:
  TinyMCE disappears from feedback form after validation fails

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  If you try post feedback, but the form validation fails, we re-display
  the feedback form. However, in this case, the TinyMCE no longer
  displays properly.

  To replicate:

  1. Create a page (which allows comments)
  2. Click on "Place feedback" on the bottom of the page
  3. Click "Submit" without filling in a comment.
  4. This will cause the feedback to fail validation, and the page will reload with a message telling you what you did wrong.

  Expected result: You should see the same feedback form, with the "Message" field displaying an error.
  Actual result: You see the feedback form, but now the "Message" field is no longer TinyMCE.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1450705/+subscriptions