← Back to team overview

mahara-contributors team mailing list archive

[Bug 1358092] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4808
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4c94f09c681943d5d2f090e71cf51df65e433270
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 4c94f09c681943d5d2f090e71cf51df65e433270
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Feb 12 10:59:50 2015 +1300

More SQL optimisation (Bug #1358092)

Allowing better sql when deleting of old notifications when
multirecipientnotification is enabled - as the code is similar to the
way account/activity/index.json.php used to be.

See patch 4144 for the change to account/activity/index.json.php

Change-Id: If7dce9527ec585b1968cbaff9028679ce7b93bcd
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit a9b36c0f0b559457027027c034f4d8834d4581e5)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1358092

Title:
  Improve SQL performance when deleting notifications

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Martin from Catalyst EU pointed out to me that the performance of the
  code in account/activity/index.json.php could be improved by stripping
  an unnecessary subquery from it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1358092/+subscriptions


References