← Back to team overview

mahara-contributors team mailing list archive

[Bug 1416890] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4840
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/22f59dbbe97b7629156d9d2fe60d4786c47cf12e
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 22f59dbbe97b7629156d9d2fe60d4786c47cf12e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Jun 16 11:51:40 2015 +1200

Regression: Adding back in the site-logo.svg file (Bug #1416890)

And fixing the phpunit tests relating to this change

Change-Id: I8ed7456fdde0427b8f921a64b44f00e1e8274df0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416890

Title:
  Use SVG images and provide backward compatibility

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Suggestion by Gilles-Philippe Leblanc:

  In the Moodle software, the images are all managed by a cascade system.
  The function initially looking if a svg file exists, then a png, then gif, jpg and ico.

  This lets you use a svg file and maintain backward compatibility.

  The system also detects if the browser supports SVG. Generally, all
  browsers support this format except Internet Explorer 8 and below.

  Everything is cached to avoid unnecessary calculation.

  So I was wondering if it was planned to add the following components to do this:
  * A library for browser detection on the server side
  * A function to find the right file extension
  * A library for caching php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416890/+subscriptions


References