← Back to team overview

mahara-contributors team mailing list archive

[Bug 1468156] Re: Migrate PluginArtefactMultirecipientnotification to a Module plugintype instead

 

I believe the steps involved will be basically this (but maybe not in
this order):

1. Move the files from htdocs/artefact/multirecipientnotification to
htdocs/module/multirecipientnotification. Likewise relocate any theme
and/or lang files.

2. Rename the PluginArtefactMultirecipientnotification class to
PluginModuleMultirecipientnotification and make it extend PluginModule
instead of PluginArtefact. Remove any unneeded PluginArtefact methods
from the class.

3. Find all URLs and paths that reference
artefact/multirecipientnotification, and rewrite them to refer to the
new location module/multirecipientnotification

4. Force the new module plugin to be installed during system upgrade.

5. Copy the content from the old artefact's tables to the new module's
tables. Or maybe just rename the tables? That would probably be faster.
Although it would conflict with the tables auto-generated by the
install.xml. Perhaps in the module's post_inst() method you could check
for the artefact tables, and if they exist, drop the module tables and
then rename the artefact tables to become the new module tables.

6. Drop the old artefact's triggers, and recreate them against the new
module tables.

5. Delete any other lingering references to the plugin, from the
database. It'll be in the "artefact_installed" table for instance.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1468156

Title:
  Migrate PluginArtefactMultirecipientnotification to a Module
  plugintype instead

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  The new Inbox was a third-party contribution authored by Tobias and
  graciously shared with the community. Unfortunately, it's a bit hacky
  that it was implemented as an artefact, since it does not provide any
  artefact functionality (i.e. no entities that are meant to be
  displayed via blocks in a portfolio Page).

  I understand the reason it was done that way, was because Tobias
  wanted to write it as a plugin (since he first wrote it for his own
  use and didn't want to hack the core), and the generic "module" plugin
  type wasn't yet available when he wrote it. But now that we have the
  "module" plugin type, we should really migrate the
  multirecipientinboxnotification to that type.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1468156/+subscriptions


References