mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Hi Jawyei,

Yes the view_access row needs to stay as the page is still expired.

If we delete the view access row (like via a cron job) then the user
would get confused as to why the view access option they set has
disappeared so we want the row to stay forever (or until the user edits
it otherwise).

Cheers

Robert

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1437929

Title:
  expired shared pages still display in groups

Status in Mahara:
  Fix Released

Bug description:
  When a page is shared with a group it appears in Group Pages->Pages
  shared with this group. If the page has a time restriction, it will
  still show in Pages shared with this group even if the end date has
  expired or if the start date is has not begun. The permission are
  correct in that if a user who does not have permission to view the
  page outside of the time restriction tries to access it, they cannot
  access the page.

  It would be better if Pages shared with this group only lists pages
  that is accessible to group. This can be done by altering line 3997 in
  ./lib/view.php in function  get_sharedviews_data($limit=10, $offset=0,
  $groupid)  from

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?);

  to

  WHERE a.group = ? AND m.member = ? AND (v.group IS NULL OR v.group !=
  ?) AND (a.startdate <= current_timestamp OR a.startdate IS NULL) AND
  (a.stopdate > current_timestamp OR a.stopdate IS NULL)';

  Checked on version 1.8 and 1.10.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1437929/+subscriptions