← Back to team overview

mahara-contributors team mailing list archive

[Bug 1468156] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4920
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/dd0e1dab78a50239829e8605f5623519b70b0f09
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit dd0e1dab78a50239829e8605f5623519b70b0f09
Author: Tobias Zeuch <tobias.zeuch@xxxxxxxxxxxxxx>
Date:   Sun Jul 5 11:22:45 2015 +0200

Bug 1468156: Change plugin type of plugin multirecipientnotification to
module

To change the plugin type from artefact to module, the code is moved and the
superclass reference is changed to PluginModule. Obsolete classes for the
former unused artefact types are deleted. The references to the old script
paths are changed. Plugin Tables are renamed and references updated.
The new plugin mustn't be installed when the old plugin is still active, but on
upgrade, the database tables are renamed and references in artefact_installed
and artefact_event_subscription and the triggers are changed.

Change-Id: Id5f1198b780ffb92181f7d60785aad9ffe2259da
Signed-off-by: Tobias Zeuch <tobias.zeuch@xxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1468156

Title:
  Migrate PluginArtefactMultirecipientnotification to a Module
  plugintype instead

Status in Mahara:
  Fix Committed

Bug description:
  The new Inbox was a third-party contribution authored by Tobias and
  graciously shared with the community. Unfortunately, it's a bit hacky
  that it was implemented as an artefact, since it does not provide any
  artefact functionality (i.e. no entities that are meant to be
  displayed via blocks in a portfolio Page).

  I understand the reason it was done that way, was because Tobias
  wanted to write it as a plugin (since he first wrote it for his own
  use and didn't want to hack the core), and the generic "module" plugin
  type wasn't yet available when he wrote it. But now that we have the
  "module" plugin type, we should really migrate the
  multirecipientinboxnotification to that type.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1468156/+subscriptions


References