← Back to team overview

mahara-contributors team mailing list archive

[Bug 1476495] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5000
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/462b1c471c851c1093797f99fbc2bc798c396c3a
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 462b1c471c851c1093797f99fbc2bc798c396c3a
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Jul 20 19:39:17 2015 +1200

Refactoring SQL query in View::shared_to_user() (Bug 1476495)

The old one unnecessarily used two separate queries for Postgres
& MySQL. And it had a bug in how it used MySQL's extended
"GROUP BY" functionality. While MySQL does let you return
non-aggregated columns, it uses an arbitrary record for these of
them, NOT the first record according to ORDER BY.

Also restructured the query a bit for optimization purposes.

behatnotneeded (Test in subsequent patch)

Change-Id: I3d49292025dcf7ac510a84d7e800476defec0525

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1476495

Title:
  Show collections in "Shared with me" screen

Status in Mahara:
  In Progress

Bug description:
  Similar to Bug 1476491 & Bug 1476492, the idea here is that we'd show
  collections on the "Shared with me" screen. (Currently it only shows
  pages, and each collection for each page is listed individually).

  This one is a little bit trickier than the other two bugs, because of
  the search bar. Presumably you'd still want to be searching the
  individual pages as well as whole collections, in which case it might
  make sense to show individual pages as well as the collections they
  belong to...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1476495/+subscriptions


References