← Back to team overview

mahara-contributors team mailing list archive

[Bug 1468156] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5028
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/8df4773f7c88a4405dc4bb08bfda7c6cfd61f5fb
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 8df4773f7c88a4405dc4bb08bfda7c6cfd61f5fb
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Jul 31 16:34:52 2015 +1200

Bug 1468156: Inbox blocktype needs to check module now

Since we moved multirecipientnotifications from artefact to module we
should now check there for it :)

Change-Id: If224ca1f323cd39d619b56a7cd1a1373afdaa04d
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1468156

Title:
  Migrate PluginArtefactMultirecipientnotification to a Module
  plugintype instead

Status in Mahara:
  Fix Committed

Bug description:
  The new Inbox was a third-party contribution authored by Tobias and
  graciously shared with the community. Unfortunately, it's a bit hacky
  that it was implemented as an artefact, since it does not provide any
  artefact functionality (i.e. no entities that are meant to be
  displayed via blocks in a portfolio Page).

  I understand the reason it was done that way, was because Tobias
  wanted to write it as a plugin (since he first wrote it for his own
  use and didn't want to hack the core), and the generic "module" plugin
  type wasn't yet available when he wrote it. But now that we have the
  "module" plugin type, we should really migrate the
  multirecipientinboxnotification to that type.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1468156/+subscriptions


References