mahara-contributors team mailing list archive

[Mahara Bot <1484296@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5088
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/486c747e7a69282fcf24fe8ca3f5c4c9abf2f66a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 486c747e7a69282fcf24fe8ca3f5c4c9abf2f66a
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Aug 13 11:08:50 2015 +1200

Typo in regex (bug 1484296)

Change-Id: Ic8810e0a46c690a7c0afe438950ca2e263504dfd
behatnotneeded: Currently can't test leap2a import/export in Behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1484296

Title:
  Typo in XML filter regex

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  A client reported this issue to me while testing the patch
  https://reviews.mahara.org/5062

  They found that after that patch was in place ALL leap import/export
  operations produced this error:

  "[WAR] export/leap/lib.php:161 preg_replace(): Compilation failed:
  non-hex character in \x{} (closing brace missing?) at offset 92"

  On inspection in the code, it's obvious that there is indeed a syntax
  error in the regex that I wrote in patch
  https://reviews.mahara.org/5061. Specifically a missing closing brace.
  It says "\x{FDEO" where it should be "\x{FDEO}". Strangely the
  presence of this syntax error did not cause any problems when running
  this code on my local machine. I suspect it may be a difference in the
  version of the PCRE library that we're running.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1484296/+subscriptions