mahara-contributors team mailing list archive

[Mahara Bot <1363753@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5115
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/45690928f036eb29ecab85e583b42e35ad5bbe19
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 45690928f036eb29ecab85e583b42e35ad5bbe19
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Aug 17 13:37:14 2015 +1200

Bug 1363753: tidying up file extract page

Supressing form error and styling the error message / form button

behatnotneeded

Change-Id: I4d627bcd45afc028cd0b85159f5c57e2a5037709
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1363753

Title:
  extract file gives error if there is not enough space for extraction

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  If I have a user that has 5MB quota and upload a zip file that is 3MB
  in size - it uploads fine

  But if I then click on the unzip icon for the file I get the useful
  message:

  'Your remaining file quota is too small to unzip this file.' - however
  this needs to be more obvious like in a error or warn message.

  But I also get:

  [WAR] c0 (artefact/file/extract.php:113) Undefined variable: form
  Call stack (most recent first):

      log_message("Undefined variable: form", 8, true, true, "/home/robertl/htdocs/mahara-devel/mahara/htdocs/ar...", 113) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:439
      error(8, "Undefined variable: form", "/home/robertl/htdocs/mahara-devel/mahara/htdocs/ar...", 113, array(size 69)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/artefact/file/extract.php:113

  I believe this is because the form isn't present when the extraction
  won't fit - but still something wants to interact with that form.

  So things to do:

  1) Make the 'Your remaining file quota is too small to unzip this
  file.' message more prominent - and also give some information on how
  to get more quota like 'contact your admin for more space and/or
  delete some files before proceeding' etc.

  2) Stop trying to access a form that is, rightly,  not there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1363753/+subscriptions