← Back to team overview

mahara-contributors team mailing list archive

[Bug 1482437] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5081
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/54865c53e6c3c5843a5622e29ab28b8ed7263fab
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 54865c53e6c3c5843a5622e29ab28b8ed7263fab
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Aug 7 12:15:23 2015 +1200

Leap2a: filter invalid XML chars on export (Bug 1482437)

behatnotneeded: Can't test contents of exported Leap2a files
in behat yet.

Change-Id: I4a309d0656e379432e3e9a62d9d4e6892980ab46
(cherry picked from commit 395afc5f4078d0f20ff0b80afb0e2a66312512bd)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1482437

Title:
  Leap2a export: Filter out ASCII control characters that are not valid
  in XML

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  This is the flip-side to Bug 1482410. The patch for that bug will
  filter out illegal ASCII control characters from XML files, which
  stops SimpleXML from choking. But Mahara is still generating invalid
  XML, by making XML files that contain those characters.

  We should add some code that also filters out invalid XML characters
  on the export side.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1482437/+subscriptions


References