mahara-contributors team mailing list archive

[Mahara Bot <785472@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5122
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/19b12b53cdcdb2bdb7024fd0a816416fba0e096f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 19b12b53cdcdb2bdb7024fd0a816416fba0e096f
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Wed Jul 30 14:22:15 2014 +1000

(Bug785472) Remove unneeded raise_memory_limit calls

On the basis of my profiling and testing over the last week,
all of the scripts affected by this patch don't need their
raise_memory_limit calls. Ensure_sanity currently sets the
memory limit to 128MB, which has been seen to be more than
sufficient for each of these use cases.

Tests have involved at least 1000 records being imported in
each case, and sometimes as many as 20,000. I would have
liked to have tested with some really full profiles (eg
lots of pictures and content), but am satisfied that there's
enough margin to cover those cases. In any case, such files
are often handled using external apps and therefore won't
be counted toward PHP's memory use anyway. Finally, the
limit can easily be increased by the user if necessary for
a particular case.

behatnotneeded

Change-Id: Ifecc83fd47da51268bae6cbd6960735eb91f9403
Signed-off-by: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
(cherry picked from commit 039564a50799e31e2048c2aed2da888cfd5dd628)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/785472

Title:
  Eliminate all raise_memory_limit() calls

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  There are very few places in Mahara were we raise PHP's memory limit,
  but it is bad practice since that memory may not be reclaimed by
  Apache until that child process is terminated.

  Unless we are confident that a particular operation is impossible to
  do without raising the memory limit, we should rewrite code which
  fails to work within 32 MB of memory.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/785472/+subscriptions