← Back to team overview

mahara-contributors team mailing list archive

[Bug 1487222] A change has been merged

 

Reviewed:  https://reviews.mahara.org/5163
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2b224d46178eafcb59327f4a753f8de9b6ed44c3
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 2b224d46178eafcb59327f4a753f8de9b6ed44c3
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Aug 24 12:27:48 2015 +1200

Bug 1487222: Loading spinner problem with TinyMCE imagebrowser

behatnotneeded: is a style change

When you submit the form after uploading an image it removes the form
completely from the DOM so that the functions formStopProcessing() and
processingStop() never get to trigger.

I've added a processingStop() to the imagebrowser code directly - this
should be fine as mahara.js is called on every page so the function
will be presesnt.

Change-Id: I2ef6b44885e75c6f032557adacd920efbf4b1aa2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487222

Title:
  Uploading an image in TinyMCE in a journal entry doesn't work

Status in Mahara:
  In Progress

Bug description:
  Mahara master 15.10dev latest pull from today

  Uploading an image via TinyMCE into a journal entry does not work. It
  works fine for the journal description itself, but not in a journal
  entry.

  To replicate:

  1. Create a new journal entry.
  2. In the journal entry TinyMCE click the image button.
  3. Select an image from your computer and try to upload it.

  Expected result: The image is uploaded.
  Actual result: The "Loading..." icon is spinning in the background and nothing really happens.

  Tested on Ubuntu 14.04, latest Firefox

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487222/+subscriptions


References